Skip to content

feat: Enable NIOFoundationCompat to compile using Swift for WebAssembly. Fix NIOCore WASI compilation issue. #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

feat: Enable NIOFoundationCompat to compile using Swift for WebAssembly. Fix NIOCore WASI compilation issue. #3422

merged 1 commit into from
Nov 5, 2025

Conversation

@scottmarchant
Copy link
Contributor

@scottmarchant scottmarchant commented Oct 22, 2025 •
edited
Loading

Fix Swift for WebAssembly compilation in NIOFoundationCompat.

Motivation:

NIO is a common dependency, and it is important to enable compiling NIO using Swift for WebAssembly. This PR fixes compilation for NIOFoundationCompat.

Modifications:

  • Fix NIOFoundationCompat compilation

Result:

With these changes, the following build commands succeed: ✅

swift build --swift-sdk wasm32-unknown-wasip1-threads --target NIOCore
swift build --swift-sdk wasm32-unknown-wasip1-threads --target NIOFoundationCompat

Context:

This PR is part of a larger effort by PassiveLogic to improve Swift for WebAssembly support

@scottmarchant
Copy link
Contributor Author

scottmarchant commented Oct 22, 2025

@MaxDesiatov @kateinoigakukun in case you're interested, I'm fixing Swift for WebAssembly compilation for NIOCore and NIOFoundationCompat in this PR.

scottmarchant
scottmarchant commented Oct 22, 2025
View reviewed changes
@scottmarchant scottmarchant mentioned this pull request Oct 22, 2025
Open
47 tasks
Lukasa
Lukasa approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Oct 23, 2025
@Lukasa
Copy link
Contributor

Lukasa commented Oct 23, 2025

This needs to be updated to the latest main. It may be helpful to get maintainers write access to your PR branches, as that allows me to make catch-up merges to main when a prior PR is merged.

@scottmarchant scottmarchant force-pushed the feat/nioFoundationCompatWASICompilation branch from c99ee33 to bf782d4 Compare October 27, 2025 23:55
@scottmarchant
Copy link
Contributor Author

scottmarchant commented Oct 28, 2025

This needs to be updated to the latest main. It may be helpful to get maintainers write access to your PR branches, as that allows me to make catch-up merges to main when a prior PR is merged.

@Lukasa Ok, this should be rebased on the tip of main now. I'll work on getting you write access to the PR source branches.

@Lukasa
Copy link
Contributor

Lukasa commented Oct 30, 2025

This PR has also fallen out of step with our main branch again, I'm afraid.

@scottmarchant scottmarchant force-pushed the feat/nioFoundationCompatWASICompilation branch from bf782d4 to 453067a Compare October 31, 2025 21:42
@scottmarchant
Copy link
Contributor Author

scottmarchant commented Oct 31, 2025

This PR has also fallen out of step with our main branch again, I'm afraid.

@Lukasa This is now rebased on the latest main.

I couldn't figure out the trick to give you write access to the branch short of adding you to our fork. I see evidence in web search results that there is a configuration to allow maintainers of the upstream fork to be able to push to PR source branches, but I can't seem to find the place to set up that configuration. If you know where I can configure that, can you send me a hint please? Happy to get that set up so you can rebase/merge as needed, and I am now prepared with admin credentials on our swift-nio fork to configure whatever is needed.

@scottmarchant scottmarchant force-pushed the feat/nioFoundationCompatWASICompilation branch from 453067a to 6934864 Compare November 3, 2025 19:03
@scottmarchant
Copy link
Contributor Author

scottmarchant commented Nov 3, 2025

Updated to rebase on latest main.

@scottmarchant scottmarchant force-pushed the feat/nioFoundationCompatWASICompilation branch from 4b5355f to fc504ea Compare November 5, 2025 16:50
@scottmarchant
Copy link
Contributor Author

scottmarchant commented Nov 5, 2025

Updated to rebase on latest main.

@Lukasa
Copy link
Contributor

Lukasa commented Nov 5, 2025

@scottmarchant This appears to be the relevant documentation page: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@Lukasa
Copy link
Contributor

Lukasa commented Nov 5, 2025

Unfortunately the format check has failed.

@scottmarchant scottmarchant force-pushed the feat/nioFoundationCompatWASICompilation branch from fc504ea to 0c76959 Compare November 5, 2025 18:49
@scottmarchant
Copy link
Contributor Author

scottmarchant commented Nov 5, 2025

Unfortunately the format check has failed.

@Lukasa Sorry about that. Latest push has a lint fix.

@scottmarchant
Copy link
Contributor Author

scottmarchant commented Nov 5, 2025 •
edited
Loading

@scottmarchant This appears to be the relevant documentation page: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@Lukasa Interesting. I read that doc previously, and maybe the doc is out of date, or else I'm missing some sort of permission.

Either way, the checkbox mentioned in that doc is missing for me.

CleanShot 2025-11-05 at 11 52 35@2x

I'll continue to watch this PR daily and make sure it is rebased, and will watch for that checkbox in new PR's.

@Lukasa Lukasa enabled auto-merge (squash) November 5, 2025 19:40
@Lukasa Lukasa merged commit cc38f7a into apple:main Nov 5, 2025
53 checks passed
@scottmarchant scottmarchant deleted the feat/nioFoundationCompatWASICompilation branch November 5, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukasa Lukasa Lukasa approved these changes

+2 more reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov left review comments

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scottmarchant @Lukasa @MaxDesiatov @kateinoigakukun